Comments on: RSpec on Rails Matchers plugin http://railsontherun.com/2008/01/04/rspec-on-rails-matchers-plugin/ Rails experiments by Matt Aimonetti Tue, 23 Feb 2010 22:05:18 +0000 hourly 1 http://wordpress.org/?v=3.3.1 By: Hugh http://railsontherun.com/2008/01/04/rspec-on-rails-matchers-plugin/comment-page-1/#comment-1599 Hugh Fri, 04 Jan 2008 03:46:00 +0000 http://railsontherun.com/2008/01/04/rspec-on-rails-matchers-plugin#comment-1599 Thanks, these are great and I've added a patch for an edit form matcher also. I wondered if these are really appropriate for packaging as a plugin with an init.rb, because won't they then get loaded when the app is run? I've just piston imported them myself (SVN external will also work) into rails_root/spec/matchers and then required them in my spec_helper.rb Thanks, these are great and I’ve added a patch for an edit form matcher also.

I wondered if these are really appropriate for packaging as a plugin with an init.rb, because won’t they then get loaded when the app is run? I’ve just piston imported them myself (SVN external will also work) into rails_root/spec/matchers and then required them in my spec_helper.rb

]]> By: Ben Mabey http://railsontherun.com/2008/01/04/rspec-on-rails-matchers-plugin/comment-page-1/#comment-1600 Ben Mabey Fri, 04 Jan 2008 03:46:00 +0000 http://railsontherun.com/2008/01/04/rspec-on-rails-matchers-plugin#comment-1600 Hey Matt, These look really nice. I haven't been able to get them working as advertised on the view specs however. I posted my woes to the rpsec-users list (here is a copy if your not on that list: http://pastie.caboo.se/139692). Anyways, if you could maybe look at what I'm doing I would appreciate it because I would really like to start using these. Thanks, Ben Hey Matt,
These look really nice. I haven’t been able to get them working as advertised on the view specs however. I posted my woes to the rpsec-users list (here is a copy if your not on that list: http://pastie.caboo.se/139692). Anyways, if you could maybe look at what I’m doing I would appreciate it because I would really like to start using these. Thanks,
Ben

]]> By: Tammer Saleh http://railsontherun.com/2008/01/04/rspec-on-rails-matchers-plugin/comment-page-1/#comment-1601 Tammer Saleh Fri, 04 Jan 2008 03:46:00 +0000 http://railsontherun.com/2008/01/04/rspec-on-rails-matchers-plugin#comment-1601 Hi Matt, I've added tests like this to the Shoulda project, which is like rSpec, but based on Test::Unit. The test aren't perfect, but have had a few eyes on them, and have been used in a lot of projects. I encourage you to check them out, and scavenge what you will for rSpec on Rails. https://svn.thoughtbot.com/plugins/shoulda/trunk Cheers, Tammer Hi Matt,

I’ve added tests like this to the Shoulda project, which is like rSpec, but based on Test::Unit. The test aren’t perfect, but have had a few eyes on them, and have been used in a lot of projects. I encourage you to check them out, and scavenge what you will for rSpec on Rails.

https://svn.thoughtbot.com/plugins/shoulda/trunk

Cheers,
Tammer

]]> By: Yossef http://railsontherun.com/2008/01/04/rspec-on-rails-matchers-plugin/comment-page-1/#comment-1602 Yossef Fri, 04 Jan 2008 03:46:00 +0000 http://railsontherun.com/2008/01/04/rspec-on-rails-matchers-plugin#comment-1602 What does it mean that you're verifying a validation has been defined, but not testing the validation itself? Looking at the code, it seems like the matcher does something that would make the validation fail and then ensures there's an error on the attribute. It sounds like testing the validation to me, but you could be meaning something else. By the way, having only one test doesn't really check the validation very well. If you're only going to have one test, it's true that it's better to check that there's an error when the attribute is nil, but that's only half the story. The other half is making sure there's no error if the attribute is not nil. Too bad you can't reliably check for anything more than a message when you're trying to pin down validations. Too bad validations couldn't be better. What does it mean that you’re verifying a validation has been defined, but not testing the validation itself? Looking at the code, it seems like the matcher does something that would make the validation fail and then ensures there’s an error on the attribute. It sounds like testing the validation to me, but you could be meaning something else.

By the way, having only one test doesn’t really check the validation very well. If you’re only going to have one test, it’s true that it’s better to check that there’s an error when the attribute is nil, but that’s only half the story. The other half is making sure there’s no error if the attribute is not nil. Too bad you can’t reliably check for anything more than a message when you’re trying to pin down validations.

Too bad validations couldn’t be better.

]]>